fix for bundle creator weirdo log file at FS root, finally, i hope.

[feisty_meow.git] / nucleus / library / configuration / application_configuration.cpp

diff --git a/nucleus/library/configuration/application_configuration.cpp b/nucleus/library/configuration/application_configuration.cpp
index a8f463ea0ada59712a3a94ea1b7f558bed2555ab..9502a3a8af715ffa6d9e9180c0a0342bdcace1bd 100644 (file)
--- a/nucleus/library/configuration/application_configuration.cpp
+++ b/nucleus/library/configuration/application_configuration.cpp
@@ -91,6 +91,7 @@ astring application_configuration::get_cmdline_from_proc()
   // command line are all separated by zero characters.
   __check_once_app_path = filebuff;
   delete [] filebuff;
+//printf("got an app name before chewing: %s\n", __check_once_app_path.s());
   // clean out quote characters from the name.
   for (int i = __check_once_app_path.length() - 1; i >= 0; i--) {
     if (__check_once_app_path[i] == '"') __check_once_app_path.zap(i, i);
@@ -100,10 +101,11 @@ astring application_configuration::get_cmdline_from_proc()
   filename testing(__check_once_app_path);
   if (testing.had_directory()) return __check_once_app_path;  // all set.
 
-//hmmm: the below might be better off as a find app in path method, which relies on which.
+//printf("no dir part found, app name after chewing: %s\n", __check_once_app_path.s());
 
+//hmmm: the below might be better off as a find app in path method, which relies on which.
   // there was no directory component, so we'll try to guess one.
-  astring temp_filename(environment::get("TMP")
+  astring temp_filename(environment::TMP()
       + a_sprintf("/zz_cmdfind.%d", chaos().inclusive(0, 999999999)));
   system((astring("which ") + __check_once_app_path + " >" + temp_filename).s());
   FILE *which_file = fopen(temp_filename.s(), "r");
@@ -189,7 +191,7 @@ astring application_configuration::query_for_process_info()
     fclose(output); \
     unlink(tmpfile.s()); \
   } \
-  astring home_dir = env_string("HOME"); \
+  astring home_dir = environment::get("HOME"); \
   to_return = home_dir + "/failed_to_determine.exe"; \
 }
 
@@ -291,27 +293,14 @@ const astring &application_configuration::LOGGING_FOLDER_NAME() { STATIC_STRING(
 
 //////////////
 
-const int MAX_LOG_PATH = 200;
+////const int MAX_LOG_PATH = 512;
   // the maximum length of the entry stored for the log path.
 
-/*
-astring application_configuration::installation_root()
-{
-  astring to_return = read_item(LOCAL_FOLDER_NAME());
-  if (!to_return) {
-    // well, if this other guy has a path, we'll give that back.  otherwise,
-    // we don't know what the path should be at all.
-    to_return = filename(application_configuration_file()).dirname();
-  }
-  return to_return;
-}
-*/
-
 astring application_configuration::get_logging_directory()
 {
-  // start with the root of our installation.
-  astring def_log = application_directory();
-///installation_root();
+  // new scheme is to just use the temporary directory, which can vary per user
+  // and which hopefully is always set to something usable.
+  astring def_log = environment::TMP();
   // add logs directory underneath that.
   def_log += "/logs";
     // add the subdirectory for logs.
@@ -321,6 +310,7 @@ astring application_configuration::get_logging_directory()
     // get the entry for the logging path.
   if (!log_dir) {
     // if the entry was absent, we set it.
+//printf("did not find log dir in config file\n");
     ini_configurator ini(application_configuration_file(),
         ini_configurator::RETURN_ONLY,
         ini_configurator::APPLICATION_DIRECTORY);
@@ -329,6 +319,7 @@ astring application_configuration::get_logging_directory()
     // they gave us something.  let's replace the environment variables
     // in their string so we resolve paths and such.
     log_dir = parser_bits::substitute_env_vars(log_dir);
+//printf("%s", (char *)a_sprintf("got log dir with %s value\n", log_dir.s()).s());
   }
 
   // now we make sure the directory exists.
@@ -354,8 +345,6 @@ astring application_configuration::get_logging_directory()
 astring application_configuration::make_logfile_name(const astring &base_name)
 { return get_logging_directory() + "/" + base_name; }
 
-///astring application_configuration::core_bin_directory() { return read_item("core_bin"); }
-
 astring application_configuration::read_item(const astring &key_name)
 {
   filename ini_name = application_configuration_file();