better naming for revision control action method.

[feisty_meow.git] / scripts / rev_control / version_control.sh

diff --git a/scripts/rev_control/version_control.sh b/scripts/rev_control/version_control.sh
index 40eb80e861d8b137fd1b851ab10630d459a978f0..8314be5e79d0cf821dbdff8eab7cc09243700fb3 100644 (file)
--- a/scripts/rev_control/version_control.sh
+++ b/scripts/rev_control/version_control.sh
@@ -220,8 +220,8 @@ function do_update()
     git pull 2>&1 | grep -v "X11 forwarding request failed" | squash_first_few_crs
     retval=${PIPESTATUS[0]}
   else
+    # this is not an error necessarily; we'll just pretend they planned this.
     echo no repository in $directory
-    retval=1
   fi
   popd &>/dev/null
   return $retval
@@ -270,21 +270,22 @@ function generate_rev_ctrl_filelist()
 
 # iterates across a list of directories contained in a file (first parameter).
 # on each directory name, it performs the action (second parameter) provided.
-function perform_action_on_file()
+function perform_revctrl_action_on_file()
 {
   local tempfile="$1"; shift
   local action="$1"; shift
 
-  dirs=($(cat $tempfile))
+#  dirs=($(cat $tempfile))
 
-  for dirname in ${dirs[@]}; do
+  while read -u 3 dirname; do
+#  for dirname in "${dirs[@]}"; do
     if [ -z "$dirname" ]; then continue; fi
-    pushd $dirname &>/dev/null
+    pushd "$dirname" &>/dev/null
     echo "[$(pwd)]"
     $action .
     echo "======="
     popd &>/dev/null
-  done 
+  done 3<"$tempfile"
 
   rm $tempfile
 }