From: Chris Koeritz <fred@gruntose.com>
Date: Fri, 8 Mar 2013 03:02:48 +0000 (-0500)
Subject: removing warnings.
X-Git-Tag: 2.140.90~1066
X-Git-Url: https://feistymeow.org/gitweb/?a=commitdiff_plain;h=cd2658c999d5ec34fc8681745037f03418eddfc2;p=feisty_meow.git

removing warnings.
---

diff --git a/nucleus/library/filesystem/filename_list.cpp b/nucleus/library/filesystem/filename_list.cpp
index 24d1522e..28ec7386 100644
--- a/nucleus/library/filesystem/filename_list.cpp
+++ b/nucleus/library/filesystem/filename_list.cpp
@@ -152,10 +152,9 @@ bool filename_list::member_with_state(const file_info &to_check, file_info::file
   return false;
 }
 
-astring filename_list::text_form() const
+astring filename_list::text_form(int max_lines) const
 {
   astring to_return;
-//hmmm: a length limit might be nice?
   for (int i = 0; i < elements(); i++) {
     to_return += a_sprintf("%d. ", i + 1);
     if (get(i))
diff --git a/nucleus/library/filesystem/filename_list.h b/nucleus/library/filesystem/filename_list.h
index f5834d79..89c91c2d 100644
--- a/nucleus/library/filesystem/filename_list.h
+++ b/nucleus/library/filesystem/filename_list.h
@@ -75,7 +75,8 @@ public:
     true if the size is different (when EQUAL_FILESIZE is true), when the timestamp is different
     (when EQUAL_TIMESTAMP is true), and when the checksum is different (you get the idea). */
 
-  basis::astring text_form() const;
+  //! max_lines is the maximum number of lines to print into the string.
+  basis::astring text_form(int max_lines = MAXINT32) const;
 
   virtual int packed_size() const;
 
diff --git a/nucleus/library/structures/hash_table.h b/nucleus/library/structures/hash_table.h
index 4eb02856..2560bc76 100644
--- a/nucleus/library/structures/hash_table.h
+++ b/nucleus/library/structures/hash_table.h
@@ -59,7 +59,7 @@ public:
   The buckets are currently simple lists, but if the hashing algorithm is well
   chosen, then that's not a major problem.  This makes lookups a lot faster
   than a linear search, but no particular performance guarantees are made at
-  this time (hmmm).
+  this time.
 */
 
 template <class key_type, class contents>
diff --git a/nucleus/library/textual/xml_parser.h b/nucleus/library/textual/xml_parser.h
index 7b2011d8..fbc96534 100644
--- a/nucleus/library/textual/xml_parser.h
+++ b/nucleus/library/textual/xml_parser.h
@@ -25,9 +25,6 @@ namespace textual {
 
 //! Parses XML input and invokes a callback for the different syntactic pieces.
 
-// hmmm, could this be the first class ever named this?  perhaps it should be
-// in a textual namespace.  -->after current sprint.
-
 class xml_parser
 {
 public:
diff --git a/nucleus/tools/clam_tools/write_build_config.cpp b/nucleus/tools/clam_tools/write_build_config.cpp
index d3b9a812..f19d3999 100644
--- a/nucleus/tools/clam_tools/write_build_config.cpp
+++ b/nucleus/tools/clam_tools/write_build_config.cpp
@@ -289,7 +289,7 @@ int write_build_config::execute()
   astring buffer;
   while (!ini.eof()) {
     int chars = ini.getline(buffer, MAX_LINE_SIZE);
-    if (!chars) continue;  // hmmm.
+    if (!chars) continue;  // hmmm: what does no chars mean?
     
     variable_tokenizer t;
     t.parse(buffer);
diff --git a/octopi/library/sockets/raw_socket.h b/octopi/library/sockets/raw_socket.h
index de98b310..99e94898 100644
--- a/octopi/library/sockets/raw_socket.h
+++ b/octopi/library/sockets/raw_socket.h
@@ -61,9 +61,6 @@ public:
 
   DEFINE_CLASS_NAME("raw_socket");
 
-//  int open(
-//hmmm...
-
   int close(basis::un_int &socket);
     // disconnects, destroys and resets the "socket" to zero.